Rename _arming -> _actuator_armed , _battery -> _battery_status in the land_detector module.
#12342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename _battery -> _battery_status in the MulticopterLandDetector class.
dagar
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR renames
_arming->_actuator_armedand_battery->_battery_statusto standardize two variables that were not included in PR #12339;_armingis utilized in multiple classes in the land_detector module, so this is also a simpler diff to review in that regard.Test data / coverage
This commit was flight tested on a 250 quad with pixhawk 4 mini:
Additional context
@dagar, this PR streamlines remaining work for #9756 and minimizes the diff in #11857 .
Please let me know if you have any questions on this PR. Thanks!
-Mark