Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NuttX to 7.29 #12344

Merged
merged 1 commit into from
Jul 10, 2019
Merged

update NuttX to 7.29 #12344

merged 1 commit into from
Jul 10, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 27, 2019

No description provided.

@dagar
Copy link
Member Author

dagar commented Jun 27, 2019

This gives a rough idea of where things changed.

dagar@dagar-desktop:~/git/Firmware$ make px4_fmu-v4_default bloaty_compare_master
[1/1] cd /home/dagar/git/Firmware/build/px4_fmu-v4_default && wget --no-verbose https://s3.amazonaws.com/px4-travis/Firmware/master/px4_...-d symbols -n 50 -C full -s vm /home/dagar/git/Firmware/build/px4_fmu-v4_default/px4_fmu-v4_default.elf -- master_px4_fmu-v4_default.elf
2019-06-26 23:34:07 URL:https://s3.amazonaws.com/px4-travis/Firmware/master/px4_fmu-v4_default.elf [24121936/24121936] -> "master_px4_fmu-v4_default.elf" [1]
     VM SIZE                               FILE SIZE
 --------------                         --------------
  [NEW] +1.87Ki lib_vscanf              +1.87Ki  [NEW]
  +125% +1.09Ki lib_vsprintf            +1.09Ki  +125%
  [NEW]    +456 __dtoa_engine              +456  [NEW]
  [NEW]    +436 nx_start                   +436  [NEW]
  [NEW]    +208 nxtask_argsetup            +208  [NEW]
  [NEW]    +160 nxthread_create            +160  [NEW]
  [NEW]    +156 strtoll                    +156  [NEW]
  [NEW]    +134 nxtask_exithook            +134  [NEW]
  [NEW]    +128 g_dtoa_round               +128  [NEW]
  [NEW]    +108 nxtask_schedsetup          +108  [NEW]
  [NEW]     +96 nxtask_spawn_exec           +96  [NEW]
  [NEW]     +96 nxtask_terminate            +96  [NEW]
  [NEW]     +96 page_sizes.7221             +96  [NEW]
  [NEW]     +88 nxtask_assignpid            +88  [NEW]
  [NEW]     +80 nxtask_exit                 +80  [NEW]
   +78%     +76 romfs_hwconfigure           +76   +78%
  [NEW]     +74 pthread_mutex_timedlock     +74  [NEW]
  [NEW]     +72 g_dtoa_scale_down           +72  [NEW]
  [NEW]     +72 g_dtoa_scale_up             +72  [NEW]
  [NEW]     +66 __ultoa_invert              +66  [NEW]
   +41%     +62 strtoull                    +62   +41%
   +53%     +56 strtoul                     +56   +53%
  [DEL]     -62 hi0bits                     -62  [DEL]
  [DEL]     -64 freelist                      0  [ = ]
 -91.4%     -64 pthread_mutex_lock          -64 -91.4%
  [DEL]     -74 utohex                      -74  [DEL]
  [DEL]     -80 task_exit                   -80  [DEL]
  [DEL]     -88 multadd.constprop.0         -88  [DEL]
  [DEL]     -88 task_assignpid              -88  [DEL]
  [DEL]     -94 lo0bits                     -94  [DEL]
  [DEL]     -96 page_sizes.7095             -96  [DEL]
  [DEL]     -96 task_spawn_exec             -96  [DEL]
  [DEL]     -96 task_terminate              -96  [DEL]
  [DEL]    -104 llutohex                   -104  [DEL]
  [DEL]    -108 task_schedsetup            -108  [DEL]
  -0.0%    -112 [89 Others]              +185Ki  +0.8%
  [DEL]    -124 pow5mult                   -124  [DEL]
  [DEL]    -134 task_exithook              -134  [DEL]
  [DEL]    -160 thread_create              -160  [DEL]
  [DEL]    -166 lshift                     -166  [DEL]
  [DEL]    -174 mult                       -174  [DEL]
  [DEL]    -184 tens                       -184  [DEL]
  [DEL]    -208 task_argsetup              -208  [DEL]
  [DEL]    -212 utoascii                   -212  [DEL]
  [DEL]    -224 quorem                     -224  [DEL]
  [DEL]    -274 llutoascii                 -274  [DEL]
  [DEL]    -360 prejustify                 -360  [DEL]
  [DEL]    -404 lib_dtoa.isra.1            -404  [DEL]
  [DEL]    -436 os_start                   -436  [DEL]
 -96.5%    -988 vsscanf                    -988 -96.5%
  [DEL] -3.35Ki __dtoa                  -3.35Ki  [DEL]
  -0.2% -2.88Ki TOTAL                    +183Ki  +0.8%

@dagar dagar force-pushed the pr-nuttx_update branch from 4127ba6 to edffa52 Compare June 27, 2019 03:15
@dagar dagar force-pushed the pr-nuttx_update branch from edffa52 to bf21346 Compare June 27, 2019 03:33
@dagar dagar changed the title WIP: update NuttX to 7.30 WIP: update NuttX to 7.29 Jun 27, 2019
@dagar dagar force-pushed the pr-nuttx_update branch 2 times, most recently from d2b4408 to eb865c0 Compare June 27, 2019 03:35
@dagar dagar marked this pull request as ready for review June 27, 2019 05:32
@dagar dagar changed the title WIP: update NuttX to 7.29 update NuttX to 7.29 Jun 27, 2019
@dagar
Copy link
Member Author

dagar commented Jun 27, 2019

We're getting low on flash in px4_fmu-v2 again.

davids5
davids5 previously approved these changes Jul 3, 2019
@dagar dagar requested a review from a team July 3, 2019 18:13
@thomasgubler
Copy link
Contributor

@MikeGoesDrones will assist in getting flight hours on this one before the merge

@davids5
Copy link
Member

davids5 commented Jul 4, 2019

@PX4/testflights , @MikeGoesDrones Please test on V5:Pro,Mini, V4:Mro,NXP, V3:Mro HW

@dagar
Copy link
Member Author

dagar commented Jul 4, 2019

Rebased on master and NuttX 7.29+ submodule updated with @bkueng's UART ioctl changes. PX4/NuttX#54

@jorge789
Copy link

jorge789 commented Jul 4, 2019

Tested on PixRacer V4:

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Log:
https://review.px4.io/plot_app?log=422782a3-8c40-4d07-89d4-6c0f4f9690cc

https://review.px4.io/plot_app?log=f6131e92-5859-4844-8fc8-ab6a94999574

Comparison to master:
https://review.px4.io/plot_app?log=b115a115-c0d9-418c-bdf9-9990201f4089

Tested on Pixhawk 2 Cube V3:

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Log:
https://review.px4.io/plot_app?log=6fbe2b9d-70b2-4030-b414-edf4c58c9247

Comparison to master:
https://review.px4.io/plot_app?log=6a5c3cca-8a5b-4beb-bb06-4b2df598869f

@dagar
Copy link
Member Author

dagar commented Jul 8, 2019

Any news @MikeGoesDrones (good or bad)?

@dannyfpv
Copy link

dannyfpv commented Jul 9, 2019

Tested on Pixhawk4 v5 f-450
Modes Tested:

Position Mode: no issue
Altitude Mode: no issue
Stabilized Mode: no issue
mission mode : no issues
pr log:
https://review.px4.io/plot_app?log=eeb8091a-f69e-4898-b618-3b7aa701d4c6

master log:
https://review.px4.io/plot_app?log=875cb2b2-79d5-4953-b13b-69fe9dba9c9e

@Junkim3DR
Copy link

Tested on Pixhawk 4mini v5:

Modes Tested:

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL: Good.

Procedure:
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

Tested on Pixhawk Pro v4:

Modes Tested:

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL: Good.

Procedure:
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

Tested on NXP FMUK66 v3:

Modes Tested:

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL: Good.

Procedure:
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:

@dagar dagar merged commit dc10a68 into master Jul 10, 2019
@dagar dagar deleted the pr-nuttx_update branch July 11, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants