Implement ModuleParams inheritance in the FixedwingLandDetector class. #12357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
fixed_wing_land_detector_module_params
branch
from
0cc4338 to
5f6e2cd
Compare
dagar
approved these changes
Jun 28, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR implements ModuleParams inheritance in the FixedwingLandDetector class and follows PR #12356.
Test data / coverage
NOTE: I do not have a fixedwing setup to test this PR.
Additional context
This PR follows work in #12209 and #12356, and streamlines remaining work for #9756.
@bkueng , @dagar . Please let me know if you have any questions on this PR. Thank you!
-Mark