Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator fix vehicle_status update #12364

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 28, 2019

The old behavior (prior to uORB::Subscription update) was to only manual set the arming state if orb_copy failed. Reposition wasn't working because of the arming check.

@BazookaJoe1900

@dagar dagar added the bug label Jun 28, 2019
@dagar dagar requested a review from julianoes June 28, 2019 22:40
@dagar
Copy link
Member Author

dagar commented Jun 29, 2019

Verified reposition is now working in SITL. All of the arming_state checks in navigator are against ARMING_STATE_ARMED and vehicle_status struct is zeroed (ARMING_STATE_INIT), so manually initializing to ARMING_STATE_STANDBY isn't necessary.

@dagar dagar merged commit 4b778fd into PX4:master Jun 29, 2019
@dagar dagar deleted the pr-navigator_vstatus branch June 29, 2019 01:35
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants