Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
The current implementation for batteries does not measure temperature, so it was reporting the temperature as 0C.
Test data / coverage
Used the MAVLink console in QGC to verify that the temperature is correctly reported as
INT16_MAX
.Describe your preferred solution
Changed internal UOrb
battery_status
message to useNAN
to represent unknown temperature. Changedmavlink_messages.cpp
to correctly convert this toINT16_MAX
as per the MAVLink message spec.