Added better logic to encode NAN as INT16_MAX to transfer to IO from FMU #12745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
previously approved these changes
Aug 19, 2019
|
Style check file - please fix, rebase and squash, thanks! |
dlwalter
force-pushed
the
pr-nans-fmu-to-io
branch
3 times, most recently
from
b49c941 to
c9391aa
Compare
Done. |
dlwalter
force-pushed
the
pr-nans-fmu-to-io
branch
2 times, most recently
from
ef8efbd to
0f61a45
Compare
changed px4io control check to isnan from not isfinite changed logic to isnan from NOT isfinite for NAN encoding style fix removed extra lines another style fix another style fix another style fix fixed some merge duplication style fixes
dlwalter
force-pushed
the
pr-nans-fmu-to-io
branch
from
0f61a45 to
e18a101
Compare
|
Commenting to possibly reopen and merge. |
julianoes
reviewed
Sep 25, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
I still wonder what happens if you end up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on PR #12743.
Changed logic to isnan() from !isfinite() to prevent INF or -INF getting encoded as NAN to the PX4IO.