Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: update to latest ecl version [continued] #13023

Merged
merged 5 commits into from
Sep 26, 2019

Conversation

kamilritz
Copy link
Contributor

This continues PR #13014

Adds ability to use velocity data from vehicle_odometry message and miscellaneous fixes for use of other data from vehicle_odometry. See PX4/PX4-ECL#642 for details

Includes ekf2_main.cpp compatibility changes for renamed variables.

@kamilritz kamilritz changed the title Pr ekf2 update continued ekf2: update to latest ecl version [continued] Sep 25, 2019
@kamilritz kamilritz force-pushed the pr-ekf2UpdateContinued branch from d062fe6 to ccc39ab Compare September 25, 2019 12:37
Copy link
Member

@mhkabir mhkabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old, now unused EV_GATE parameter needs to removed

Nvm, seems to be gone. I blame reviewing on mobile

mhkabir
mhkabir previously approved these changes Sep 25, 2019
@mhkabir
Copy link
Member

mhkabir commented Sep 25, 2019

Please fix style.

src/modules/ekf2/ekf2_main.cpp bad formatting, please run "make format" or "./Tools/astyle/fix_code_style.sh src/modules/ekf2/ekf2_main.cpp"

TSC21
TSC21 previously approved these changes Sep 25, 2019
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a style fix

@kamilritz kamilritz dismissed stale reviews from TSC21 and mhkabir via 04bb803 September 26, 2019 07:05
@jkflying jkflying merged commit 190c817 into PX4:master Sep 26, 2019
@TSC21
Copy link
Member

TSC21 commented Sep 26, 2019

Nice work @kamilritz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants