Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recently added vehicle_attitude.timestamp check from MulticopterLandDetector::_get_maybe_landed_state(). #13072

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Remove recently added vehicle_attitude.timestamp check from MulticopterLandDetector::_get_maybe_landed_state(). #13072

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df222d7
Remove recently added vehicle_attitude.timestamp check from Multicopt…
mcsauder Oct 2, 2019
d0c4754
Merge remote-tracking branch 'upstream/master' into vehicle_attitude_…
mcsauder Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/land_detector/MulticopterLandDetector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ bool MulticopterLandDetector::_get_maybe_landed_state()
const hrt_abstime now = hrt_absolute_time();

// When not armed, consider to be maybe-landed
if (!_actuator_armed.armed || (_vehicle_attitude.timestamp == 0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_vehicle_attitude is now unused and can be removed completely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_vehicle_attitude is now unused and can be removed completely

Thanks @bkueng ! Fixed with #13134

if (!_actuator_armed.armed) {
return true;
}

Expand Down