Takeoff: add back implicit fallthrough warning (testing where CI might fail) #13104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might as well get rid of the same compiler flag in the LED module. I can check that tomorrow. |
|
Ah, wasn't that the ccache bug with the version that ships with Ubuntu 16.04? |
|
My overall plan was to bump us to c++17 once the snapdragon toolchain is updated. |
Yes. If you update ccache it should all work as expected, I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I don't exactly understand what #13084 tries to achieve or if there's no simpler solution I'm removing the line that ignores the warning to see if CI actually fails on some platform because my setup does not fail to compile it.