-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensors split rc_update into new standalone module #13241
Conversation
a5d2464
to
8fe0ff2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
The new module could probably use a better name. Any suggestions? |
Here are a few thoughts to throw at the wall, nothing I am completely in love with either though: RCSignalMapper, RCSignalHandler, RCInputHandler, RCHandler |
Tested on PixRacer V4: Position Mode: Good. - Procedure Notes: Log: https://review.px4.io/plot_app?log=b0dfe561-655a-4c14-8471-8fb52849151c |
Tested on NXP FMUK66 v3Modes Tested Procedure Notes: Log: https://review.px4.io/plot_app?log=cd0c9fda-cd66-47c7-97ad-a93e19fbecee Tested on Pixhawk Pro v4Modes Tested Procedure Notes: Log: https://review.px4.io/plot_app?log=c100d678-ee95-4aa3-8897-9fa0e559f0d0 |
Tested on Pixhawk 4 V5 Modes Tested Procedure Notes: |
Thanks for the review and testing. This will be easy to rename and refactor as a standalone module. |
This PR splits the rc update handling (rc_update) out of the sensors module monolith, similar to #13073 and #12601.
In isolation this change isn't that interesting, although it likely removes a bit of latency in RC updates and has some potential side benefits for truly RC-less systems. The larger goal is to reduce the sensors module complexity and get to the point where it's not a bottleneck for running multiple estimators. By splitting these logical pieces into separate modules they become a bit easier to manage and refactor.
A follow up PR could update this new module to properly use module parameters.