NuttX cmake bug fixes and improvements #13490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-nuttx_make_defs_race
branch
4 times, most recently
from
d8a7b12 to
620a44b
Compare
|
NuttX cmake improvements
|
dagar
force-pushed
the
pr-nuttx_make_defs_race
branch
4 times, most recently
from
a8ad92d to
a9b155e
Compare
|
The root cause of the failure on MacOS was a race condition regenerating the config.h header between builds nuttx libs and apps. There's a proper dependency at the cmake level now. |
dagar
changed the title
dagar
force-pushed
the
pr-nuttx_make_defs_race
branch
from
a9b155e to
5ed5c66
Compare
- fix temporary Make.defs copy - implement custom macros for COMPILE, COMPILEXX, ASSEMBLE, ARCHIVE to enable ccache properly (if available and enabled) - fix NuttX mkdeps - fix libapps race condition with context
dagar
force-pushed
the
pr-nuttx_make_defs_race
branch
from
5ed5c66 to
8420103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the intermittent MacOS NuttX build failure in the recent upgrade (#13065).