Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes V5 and V5X over current not being reported #13758

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fixes V5 and V5X over current not being reported #13758

merged 2 commits into from
Dec 18, 2019

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Dec 17, 2019

As recommended in the BQ24315 datasheet V5 introduced a series 47K Ohm resistor in the FAULT line connection to the CPU on GPIO_VDD_5V_HIPOWER_OC and GPIO_VDD_5V_PERIPH_OC.

This PR remove the pullup in GPIO config for GPIO_VDD_5V_HIPOWER_OC and GPIO_VDD_5V_PERIPH_OC to correct VinL when /FAULT is true.

FMUV5 Before this PR with 2A load on Telem1 & Telem2

 system_power_s
        timestamp: 564569926  (0.000410 seconds ago)
        voltage5v_v: 5.1321
        voltage3v3_v: 3.3322
        v3v3_valid: 1
        usb_connected: 0
        brick_valid: 1
        usb_valid: 0
        servo_valid: 1
        periph_5v_oc: 0
        hipower_5v_oc: 0

FMUV5 With this PR with 2A load on Telem1 & Telem2

 system_power_s
        timestamp: 564569926  (0.000410 seconds ago)
        voltage5v_v: 5.1321
        voltage3v3_v: 3.3322
        v3v3_valid: 1
        usb_connected: 0
        brick_valid: 1
        usb_valid: 0
        servo_valid: 1
        periph_5v_oc: 1
        hipower_5v_oc: 1

FYI @DuganY

@davids5 davids5 requested a review from LorenzMeier December 17, 2019 23:54
@davids5 davids5 added the bug label Dec 17, 2019
@davids5 davids5 requested a review from dagar December 17, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants