Pre-flight check: add parameter to en/disable mag field strength check #13766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaEtUgR
reviewed
Dec 20, 2019
src/modules/commander/Arming/PreFlightCheck/checks/ekf2Check.cpp
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| success = false; | ||
| goto out; | ||
| } | ||
|
|
||
| param_get(param_find("COM_ARM_MAG_STR"), &is_mag_strength_check); |
There was a problem hiding this comment.
I would fill the local variable when it's declared. Ideally here but if you have to declare it earlier because of the **** gotos I would move the param_get() there as well.
There was a problem hiding this comment.
I hope we can get rid of those ugly goto at some point...
src/modules/commander/Arming/PreFlightCheck/checks/ekf2Check.cpp
Outdated
Show resolved
Hide resolved
bresch
force-pushed
the
pr-mag-str-preflt
branch
from
9f5927e to
8c1ad76
Compare
|
@MaEtUgR I addressed your comments, can you review again please? |
dagar
approved these changes
Dec 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter:
COM_ARM_MAG_STRdefines if thepre_flt_fail_mag_field_disturbedflag sent by the estimator should prevent arming or not.