-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support large number of vehicles in multivehicle SITL #14126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Feb 10, 2020
96b4b8d
to
8c9aa48
Compare
bkueng
reviewed
Feb 18, 2020
bkueng
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishwillee fyi
This was referenced Feb 18, 2020
Merged
jkflying
pushed a commit
that referenced
this pull request
Feb 18, 2020
There was a shellcheck failure in CI. http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-14126/4/pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Previously, the number of vehicles that were able to be simulated was limited to 10 vehicles. This was due to a overlap on port numbering that overlapped in the rcS definition.
Describe your solution
Redefine gcs udp port from
14570
to18570
in rcS.Test data / coverage
Tested up to 100 instances of vehicles on a desktop.
Image below shows 30 vehicles