Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vehicle type: Airship #14862
New vehicle type: Airship #14862
Changes from 10 commits
e2d9bad
e3f1229
f63a446
cc3e36a
fca67cd
b00888c
d04899a
da5f504
b6a2223
6a2b4ee
b30acd3
9921453
76b77e4
4bd3f4f
e3ec272
7bd6474
64bd184
8cbebee
e46ca85
6ad0172
b60a32d
08129ab
c1c859c
06677f7
b4c6675
669e227
384662e
9855b09
1e53880
fa46136
9b9832e
fcaa8b3
1be3b55
ab7cbb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is currently using MAV_TYPE 2. It would be ideal to use MAV_TYPE 7, but the implementation seems non-trivial at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be set to
MAV_TYPE 7
and may be specifyn=0
at https://github.com/PX4/Firmware/blob/master/src/modules/simulator/simulator_mavlink.cpp#L104. This way you are explicitly stating that the control inputs range from -1 ~ 1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the default already, so no need to have them here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-leo why did you mark this as resolved? I don't see this being addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng I didn't realize that when defined as a pwm parameter they already have those exact defaults. Updated, thanks!