rotation: add ROTATION_ROLL_270_YAW_225 and ROTATION_ROLL_270_YAW_315 #15343
Conversation
|
Who will send a PR to the QGC repo for the matching rotation ENUM? Have you checked the sync to MAVLink? |
|
@LorenzMeier Then we should maybe keep them as our custom rotations. I honestly do not see anyone else using these exact numbers and hence I also don't see why supporting them explicitly in MAVLink and QGC is worth any effort. The system needs to allow setting an arbitrary custom mag orientation that would be worth the effort. |
| @@ -102,9 +102,11 @@ PARAM_DEFINE_INT32(CAL_MAG0_EN, 1); | |||
| * @value 43 Pitch 90°, Yaw 180° | |||
| * @value 44 Pitch 9°, Yaw 180° | |||
| * @value 45 Pitch 45° | |||
| * @value 46 Roll 270°, Yaw 225° | |||
There was a problem hiding this comment.
Add a value of 1000 here that means "custom". Then add three parameters for the angles (in degrees) for all three. Then wrap the rotate function (please don't add parameters into it, because those are runtime heavy) in the mag driver where it will either take one of the standard ones, or if you have set it to custom, where it will read these parameters and apply a full rotation.
|
Since this got a placeholder for custom rotations I'm closing. |
Describe problem solved by this pull request
These rotations were missing and there's no way to set completely custom ones.
Describe possible alternatives
This shows that we should enable to use custom rotations.
Test data / coverage
These were tested and used on a real vehicle.
Additional context
#14797
#15264