Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing detector for V1 boards as well. #1694

Merged
merged 1 commit into from
Jan 24, 2015

Conversation

sjwilks
Copy link
Contributor

@sjwilks sjwilks commented Jan 24, 2015

This adds the landing detector module to V1 setups. This will also fix a startup failure on V1's as it's in the startup script already.

Note that "free" shows a drop from 32k to 19k once this module is active. @Zefz I noticed the reserved stack space is 1200 but after boot it's using 400. Does it go much higher than this?

@LorenzMeier
Copy link
Member

@sjwilks Does the free stack or the continuos free stack drop that significant? I would expect an usage of ~5K with all OS buffer overhead.

@LorenzMeier
Copy link
Member

Is this related to the boot issue with the microSD card?

@sjwilks
Copy link
Contributor Author

sjwilks commented Jan 24, 2015

That could be though it's intermittent but stack usage is consistent. But I
agree it would make sense to come back to that after this issue is
resolved.

On Sat, 24 Jan 2015 15:05 Lorenz Meier [email protected] wrote:

Is this related to the boot issue with the microSD card?


Reply to this email directly or view it on GitHub
#1694 (comment).

@LorenzMeier
Copy link
Member

Could you paste the raw output of free? I still don't understand these numbers.

@sjwilks
Copy link
Contributor Author

sjwilks commented Jan 24, 2015

Never mind. It's simply because when the land_detector module wasn't included in the build the startup script failed and exited early, hence the lower stack usage.

So it's really only a question of the stack size but you've filed a general bug related to this so that should be enough not to forget.

LorenzMeier added a commit that referenced this pull request Jan 24, 2015
Add landing detector for V1 boards as well.
@LorenzMeier LorenzMeier merged commit 91c6054 into PX4:master Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants