Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iridium: disable module for now #17837

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Iridium: disable module for now #17837

merged 3 commits into from
Jul 2, 2021
+187 −236

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Jul 2, 2021

  • fixes hardfault on boot if no device attached
  • still disabling the module for now as there are more issues (@RomanBapst will provide the details)

I don't have hw to test with.

bkueng added 3 commits July 2, 2021 11:28
@bkueng
ModuleBase: allow configurable timeout for wait_until_running()
6d7e0a1
@bkueng
fix iridiumsbd: use ModuleBase
c7fb67e 
fixes hardfaults, e.g. when device not connected
@bkueng
iridiumsbd: disable module until everything is fixed
bf03fe1 
There seem to be more issues in combination with MAVLink.
@bkueng bkueng mentioned this pull request Jul 2, 2021
Closed
@LorenzMeier LorenzMeier merged commit 50b0f0e into master Jul 2, 2021
@LorenzMeier LorenzMeier deleted the iridium_disable branch July 2, 2021 10:45
@dagar dagar mentioned this pull request Aug 22, 2021
Closed
@julianoes julianoes mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkueng @LorenzMeier