Add indicated airspeed to uavcannode #21116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Feb 14, 2023
dirksavage88
force-pushed
the
indicated_as
branch
from
45297f5 to
02aef8b
Compare
|
@dagar merge conflicts were resolved |
|
@dagar can you please have a look? If we don't actively work on it or have work planned we should remove it from the project board. |
|
Rebased. |
… and uavcannode Signed-off-by: dirksavage88 <[email protected]>
dirksavage88
force-pushed
the
indicated_as
branch
from
0b760cd to
9ee528e
Compare
Signed-off-by: dirksavage88 <[email protected]>
dagar
reviewed
Jan 23, 2024
Signed-off-by: dirksavage88 <[email protected]>
|
|
dagar
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dirksavage88 [email protected]
Add indicated airspeed in order to use dronecan airspeed sensors in uavcannode.
Sensors by default only publish to raw air data (differential pressure, static press., static temp). Adding indicated airspeed and thus having the sensors module on a dronecan node allows distributed airspeed sensor measurements.
Existing solutions: problematic i2c cable runs, comm errors plagued these sensors in the past: #6314
Uavcannode support can help pave a path towards #12237
True airspeed, sideslip, and AoA can also be brought in as they are in the dsdl, however I'm not sure if they should be under separate publishers, as indicated AS publisher is required to calibrate and use the airspeed sensor at a minimum.