fw pos control: revert name until we delineate this module a bit more #21442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
previously approved these changes
Apr 6, 2023
sfuhrer
previously approved these changes
Apr 6, 2023
|
@tstastny Could you rebase this so we can get it in? I think it is important to get this in before we get anything else in for fw pos control |
|
@Jaeyoung-Lim done. Let's merge once CI passes. |
sfuhrer
force-pushed
the
revert-fw-pos-controller-name
branch
from
e993101 to
060e765
Compare
sfuhrer
approved these changes
Apr 13, 2023
|
Tailsitter failing, but probably not related. @junwoo091400 Was this fixed? I think the intermittent failure is still there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new name will probably cause more confusion than necessary .. and isnt totally true at the moment. once we have a path following module, we can call it that ;)
was changed in #19629