Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirspeedSelector: Only do airspeed scale estimation and airspeed validation with valid GNSS fusion #23268

Merged

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Jun 14, 2024

Compared to GNSS, alternate position observation methods are less accurate and thus generally not good enough to do airspeed validation with. Airspeed validation is thus disabled if no GNSS fusion is happening.

Changelog Entry

For release notes:

Improvement: Only do airspeed scale estimation and airspeed validation with valid GNSS fusion

Alternatives

  • Directly fuse GNSS into the airspeed validator (to then be used for wind estimate), instead of using local_position but only if GNSS is fused --> I think this is the way to go, but we then need to figure out how to do signal validation (is using estimator_gps_status.checks_passed enough?).

Compared to GNSS, alternate position observation methods are less accurate
and thus generally not good enough to do airspeed validation with.
Airspeed validation is thus disabled if no GNSS fusion is happening.

Signed-off-by: Silvan Fuhrer <[email protected]>
@sfuhrer sfuhrer requested a review from bresch June 14, 2024 10:06
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yes

@bresch
Copy link
Member

bresch commented Jun 14, 2024

but we then need to figure out how to do signal validation (is using estimator_gps_status.checks_passed enough

Yes, this should be enough

@sfuhrer sfuhrer merged commit f646f1b into main Jun 14, 2024
92 of 93 checks passed
@sfuhrer sfuhrer deleted the pr-airspeed-validator-only-update-wind-est-with-gnss-main branch June 14, 2024 15:10
chiara-septentrio pushed a commit to flyingthingsintothings/PX4-Autopilot that referenced this pull request Jul 3, 2024
Compared to GNSS, alternate position observation methods are less accurate
and thus generally not good enough to do airspeed validation with.
Airspeed validation is thus disabled if no GNSS fusion is happening.

Signed-off-by: Silvan Fuhrer <[email protected]>
chiara-septentrio pushed a commit to flyingthingsintothings/PX4-Autopilot that referenced this pull request Jul 4, 2024
Compared to GNSS, alternate position observation methods are less accurate
and thus generally not good enough to do airspeed validation with.
Airspeed validation is thus disabled if no GNSS fusion is happening.

Signed-off-by: Silvan Fuhrer <[email protected]>
vertiq-jordan pushed a commit to iq-motion-control/PX4-Autopilot that referenced this pull request Aug 21, 2024
Compared to GNSS, alternate position observation methods are less accurate
and thus generally not good enough to do airspeed validation with.
Airspeed validation is thus disabled if no GNSS fusion is happening.

Signed-off-by: Silvan Fuhrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants