Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take 2: Cleanup circular dependencies ActuatorEffectiveness #24197

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Jan 10, 2025

... and actuator effectiveness

Solved Problem

ControlAllocation lib depends on ActuatorEffectivenss lib. However, some of the vehicle specific ActuatorEffectiveness was including ControlAllocation while nothing was used.

Solution

Remove circular dependency

Changelog Entry

For release notes:

Feature/Bugfix Removed circular dependency of ActuatorEffectiveness and ControlAllocation

Alternatives

We could also just look the other way. To make life more interesting, maybe we can chain multiple libraries to then form a longer circular dependency. This would be harder to spot.

Test coverage

SITL builds.

make px4_sitl gazebo-classic

Context

@sfuhrer sfuhrer merged commit f5c05f6 into main Jan 13, 2025
60 of 61 checks passed
@sfuhrer sfuhrer deleted the pr-fix-more-circular-dependencies branch January 13, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants