Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: do not auto-generate sideslip measurement jacobian #24218

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

bresch
Copy link
Member

@bresch bresch commented Jan 15, 2025

This is to trade a bit of CPU load for more flash space.

Sideslip is fused at low rate (~6Hz) and just a single measurement.

This is to trade a bit of CPU load for more flash space.
@bresch bresch requested a review from dagar January 15, 2025 13:55
@bresch bresch self-assigned this Jan 15, 2025
@bresch bresch requested a review from MaEtUgR January 15, 2025 13:56
Copy link

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: -1960 byte (-0.1 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +40  [ = ]       0    .debug_frame
+0.0%    +347  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%    +351  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0% -1.37Ki  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.4% -1.35Ki  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%    -567  [ = ]       0    .debug_loc
  -0.0%     -32  [ = ]       0    [section .debug_loc]
  -0.1%    -535  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +161  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.1%    +168  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  +1.5%      +1  [ = ]       0    task/task_cancelpt.c
-0.0%     -38  [ = ]       0    .debug_str
  -0.0%     -38  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-1.0%      -2  [ = ]       0    .shstrtab
-0.0%     -34  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +32  [ = ]       0    [section .strtab]
  -0.2%     -34  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
 +18% +1.91Ki  [ = ]       0    [Unmapped]
-0.1% -1.91Ki  -0.1% -1.91Ki    .text
  +0.0%      +5  +0.0%      +5    [section .text]
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -1.1% -1.92Ki  -1.1% -1.92Ki    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0% -1.41Ki  -0.1% -1.91Ki    TOTAL

px4_fmu-v6x [Total VM Diff: -1968 byte (-0.1 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +40  [ = ]       0    .debug_frame
+0.0%    +347  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.0%    +351  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0% -1.37Ki  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.4% -1.35Ki  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%    -527  [ = ]       0    .debug_loc
  -0.0%     -30  [ = ]       0    [section .debug_loc]
  -0.1%    -497  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +157  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.1%    +168  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  -4.5%      -3  [ = ]       0    task/task_cancelpt.c
-0.0%     -38  [ = ]       0    .debug_str
  -0.0%     -38  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.9%      -2  [ = ]       0    .shstrtab
-0.0%     -34  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +32  [ = ]       0    [section .strtab]
  -0.2%     -34  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+2.8% +1.92Ki  [ = ]       0    [Unmapped]
-0.1% -1.92Ki  -0.1% -1.92Ki    .text
  -1.1% -1.92Ki  -1.1% -1.92Ki    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0% -1.38Ki  -0.1% -1.92Ki    TOTAL

Updated: 2025-01-15T14:00:47

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes quite a difference 😲📈

@dagar dagar added the EKF2 label Jan 15, 2025
@dagar dagar merged commit c99cb6e into main Jan 15, 2025
61 checks passed
@dagar dagar deleted the pr-ekf2_sideslip_no_k branch January 15, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants