Fix usage of CRTSCTS define from termios.h #6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
force-pushed
the
flowctrl_fix
branch
from
d4773d7 to
e7766b5
Compare
|
@LorenzMeier I tested branch flwctrl_fix and it fixed the issue:
Instance #2 now shows a rate multiplier of 1.0. I also tested the companion connection with success. |
LorenzMeier
force-pushed
the
flowctrl_fix
branch
from
e7766b5 to
4df9021
Compare
|
Awesome, thanks! I also attributed your contribution in finding and fixing this in the commit. |
NuttX had the CRTSCTS define incorrectly set for only output flow control, which broke our flow control logic. This commit patches NuttX and puts in addition a guard in place to prevent any future issue with the non-POSIX define being incorrect. This has been debugged and identified by @ecmnet, which was the main contribution for this patch.
LorenzMeier
force-pushed
the
flowctrl_fix
branch
from
4df9021 to
410dfcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuttX had the CRTSCTS define incorrectly set for only output flow control, which broke our flow control logic. This commit patches NuttX and puts in addition a guard in place to prevent any future issue with the non-POSIX define being incorrect.
@ecmnet Could you quickly test this and provide the output of
mavlink status? Give it 15 seconds or so to auto-disable flow control if your link does not support flow control. Do you have the flow control lines connected and does your radio link support flow control?