Navigator: Fix RTL command lnd logic for missions #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The navigator was sending RTL commands in the wrong circumstances leading to a cycle between Navigator and Commander.
julianoes
reviewed
May 16, 2017
|
The logic was completely wrong. If you look at the whole file you'll see that what I removed responded to a RTL command, not a mission item. The mission item handling is still in. |
|
Got it, thanks. |
|
This seems to disable the back-transition before landing in RTL. However I cannot test it on 1.6.2 or master since I need quite some additional code for my airframe to work. |
|
@bartslinger can you open a new issue to discuss? We can quickly verify in SITL. |
sanderux
reviewed
Jun 13, 2017
| if (!item_contains_position(&_mission_item)) { | ||
| issue_command(&_mission_item); | ||
| } | ||
|
|
There was a problem hiding this comment.
@LorenzMeier Removing this breaks the backtransition before landing in rtl on a vtol
There was a problem hiding this comment.
LorenzMeier
added a commit
that referenced
this pull request
Jun 14, 2017
A recent change removed the command forwarding required for VTOL transitions. This change brings this back. Partially reverts #7249
|
Fix in: #7418 |
LorenzMeier
added a commit
that referenced
this pull request
Jun 15, 2017
A recent change removed the command forwarding required for VTOL transitions. This change brings this back. Partially reverts #7249
LorenzMeier
added a commit
that referenced
this pull request
Jun 17, 2017
A recent change removed the command forwarding required for VTOL transitions. This change brings this back. Partially reverts #7249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navigator was sending RTL commands in the wrong circumstances leading to a cycle between Navigator and Commander.