-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuttX upgrade split UAVCAN bootloaders into separate repository #7878
Conversation
@dagar - some feedback I tested px4esc-v1 and it works. So I would assume, that all should Some minor issues: The git hash it was tied to was not in repo I checked out the px4_nuttx-master - it is building .gitignore list_config_targets needs .project .cproject .settings Make is tad broken:
I needed debug symbols, can not set build type from command line
I had to edit cmake to get RelWithDebInfo but then px4cannode-v1 will not fit :(.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagar see comments.
It was building MinSizeRel (-Os), RelWithDebInfo is actually -O2. Like with firmware I'll keep it at MinSizeRel, but manually add -g. Does it actually need the nuttx patches? Whatever we point nuttx at should have a corresponding branch. I'll update .gitignore and try to fix Make magic. |
I am on the fence. If an upstream change breaks uavcan BL, it means I most likely need to check why thing grew. But on the other hand, locking down to a version that works - may be be good enough. We could also tie it to a new branch px4_nuttx-uavcan_bootloaders and fix the one commit that made it not fit. |
Try https://github.com/dagar/bootloaders_uavcan again. I think I've addressed everything.
|
@dagar debuggable and fits.
|
40ede1e
to
bbd6f7d
Compare
I'll remove bootloaders from semaphore and rebase. |
PX4 org repositories created. We should add a README, LICENSE, git description. Anything else? |
85828d1
to
83e6397
Compare
- essentially reverting #7878 minus the obsolete board support
New repos (would move to PX4 org)
https://github.com/dagar/bootloaders_uavcan
https://github.com/dagar/uavcan_board_ident
Duplicated between Firmware and bootloaders_uavcan