-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuttX cmake generate Make.defs from PX4 #8573
Conversation
51187b7
to
f2b21ae
Compare
nuttx-configs/auav-x21/nsh/Make.defs
Outdated
# We only support building with the ARM bare-metal toolchain from | ||
# https://launchpad.net/gcc-arm-embedded on Windows, Linux or Mac OS. | ||
# | ||
CONFIG_ARMV7M_TOOLCHAIN := GNU_EABI${HOST_OS_FIRST_LETTER} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagar what happens here to get GNU_EABI{L|W} for nuttx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Inline comment - If it works on Linux I am good with it.
f2b21ae
to
b922e64
Compare
@MaEtUgR or @hamishwillee could you give this branch a quick try on your cygwin setup? Any nuttx build will do. |
b922e64
to
4757603
Compare
If we ever want to do real native toolchain windows builds this is likely going to have implications for the NuttX side, however we'll be in a much better position to handle the issues sanely from PX4 cmake. |
4757603
to
b835d0c
Compare
I don't have a current setup. @MaEtUgR ? |
Late to the party. Broke it like I wrote here. Just for reference the first error is:
And all the following look exactly the same. I'll have a look. |
Each nuttx-config's Make.defs is nearly identical except for architecture specific compiler flags which PX4 cmake already has. We can generate this file for each nuttx-config, inheriting the cpu flags from PX4. Additional NuttX flags can be added to
nuttx-configs/Make.defs.in
.TODO: test on windows