aerofc: Look for px4flow sensor on telemetry port #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugnanprabhu
force-pushed
the
aero_px4flow
branch
from
0e93966 to
f133bbd
Compare
sugnanprabhu
changed the title
Signed-off-by: Sugnan Prabhu S <[email protected]>
dagar
requested changes
Mar 2, 2018
src/drivers/px4flow/px4flow.cpp
Outdated
| @@ -754,6 +754,10 @@ start(int argc, char *argv[]) | |||
| #ifdef PX4_I2C_BUS_ONBOARD | |||
| PX4_I2C_BUS_ONBOARD, | |||
| #endif | |||
| #ifdef CONFIG_ARCH_BOARD_AEROFC_V1 | |||
There was a problem hiding this comment.
Please don't use board specific defines outside of the board support (currently src/drivers/boards/aerofc-v1).
What about ifdef PX4_I2C_BUS_EXPANSION1?
sugnanprabhu
force-pushed
the
aero_px4flow
branch
from
f133bbd to
3c331d0
Compare
dagar
approved these changes
Mar 30, 2018
|
Sorry for the delay, github didn't notify me you made the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user connects the px4flow sensor on telemetery port of intel aero, it is not working as px4flow sensor driver is not looking for the desired slave address on the expansion port.