This makes QGC connect with crazyflie #9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in PX4#8924
LorenzMeier
approved these changes
Mar 16, 2018
|
@bueng is the crazyradio UART correctly configured and all input handling (CR, LF) disabled? This change looks like it’s working around that. |
|
Please compare how the UART is configured in the MAVLink app. It needs that. |
|
The change here looks strange to me too. I already gave @barzanisar a commit to test that changes the settings to disable input handling (as |
|
Ok I tried @bkueng 's changes instead and QGC connects. So I guess no need to change # CONFIG_DEV_LOWCONSOLE to CONFIG_DEV_LOWCONSOLE=y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #8924