Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_att_control: revert to tested cutoff frequency #9162

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Mar 26, 2018

Revert the disabled d term filter which needs to be enabled
after reducing IMU filtering and was probably unintentionally
during a rebase.

Likely fixes #9150

Revert the disabled d term filter which needs to be enabled
after reducing IMU filtering and was probably unintentionally
during a rebase.
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't realize that

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Mar 26, 2018

More detailed explanation:

  • Before MC rate controller: add low-pass filter for D-term #8920 the default cutoff frequency for the software filter for IMU was 30Hz
  • After this pr the user was able too choose cutoff in general and cutoff for the d term of the rate controller separately. But the default was still 30Hz generall, separate D term filter disabled MC_DTERM_CUTOFF = 0.
  • With Update IMU gyro and D term filter defaults #9070 the default was changed according to experiments with a variety of vehicles. The general cutoff for gyroscope was raised to 80Hz and the D term cutoff was enabled to 30Hz such that no D term noise gets to the output.
  • In Multicopter mixer saturation handling strategy -- continue #9062 the D term cutoff was accidentally disabled again probably because of rebase conflicts resulting in a high general cutoff and nothing attenuating the D term noise.
  • This possibly resulted in sudden unstable flight depending on vehicle and tuning with master and default parameters which was luckily spoted and reported by the test team in MultiRotor: Unstable manual flight #9150.

@MaEtUgR MaEtUgR merged commit 2acd431 into master Mar 26, 2018
@MaEtUgR MaEtUgR deleted the pr-d-cutoff-hotfix branch March 26, 2018 12:23
@bresch
Copy link
Member

bresch commented Mar 26, 2018

@MaEtUgR Thanks!

@santiago3dr
Copy link

https://logs.px4.io/plot_app?log=8933a3e8-c062-44a0-a9be-8c01eb725a7e

hotfix working; stable flight in manual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiRotor: Unstable manual flight
4 participants