px4iofirmware use std NAN instead of undefined 0.0f/0.0f #9280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -604,7 +591,7 @@ mixer_callback(uintptr_t handle, uint8_t control_group, uint8_t control_index, f | |||
|
|
|||
| if (should_prearm && control_group == actuator_controls_s::GROUP_INDEX_ATTITUDE && | |||
| control_index == actuator_controls_s::INDEX_THROTTLE) { | |||
| control = NAN_VALUE; | |||
| control = std::numeric_limits<float>::quiet_NaN(); | |||
There was a problem hiding this comment.
My one concern about this line is that std::numeric_limits<float>::quiet_NaN() can actually return a number that is not Nan if they are unsupported for the datatype. You can check their support by putting an assert on std::numeric_limits<float>::has_quiet_NaN to make sure. Alternatively you could also use the NAN macro here as was done in the mixer.cpp as I believe this macro is only defined if the NAN exists.
| @@ -37,21 +37,6 @@ | |||
| * Simple summing mixer. | |||
| */ | |||
|
|
|||
| #include <px4_config.h> | |||
There was a problem hiding this comment.
I am not sure I am up to reviewing the parts of the code where you have removed a large number of includes, however if it still compiles I guess they were not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZacharyTaylor please review.