param_shmem sync with param #9293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-param_shmem_sync
branch
from
d16537e to
e33de1f
Compare
|
@bkueng this is low priority, but I was thinking we should merge param_shmem into the regular param. This PR gets them close to in sync again. |
bkueng
previously approved these changes
Apr 16, 2018
There was a problem hiding this comment.
Looks good.
@DanielePettenuzzo @ChristophTobler Can one of you test this on Snappy please?
| param_unlock(void) | ||
| param_unlock_reader(void) | ||
| { | ||
| // TODO: this doesn't seem to work on Snappy |
| } | ||
|
|
||
| state.mark_saved = mark_saved; | ||
|
|
||
| do { | ||
| result = bson_decoder_next(&decoder); | ||
| usleep(1); |
|
@DanielePettenuzzo Could you please test this with Nico? This might very well resolve the boot issue you had. |
|
@dagar @LorenzMeier we have this boot issue also with this pr. |
dagar
force-pushed
the
pr-param_shmem_sync
branch
from
e33de1f to
4c7d18b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step is merging this.