This repository has been archived by the owner on May 1, 2024. It is now read-only.
Revert "cmake standalone" #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PX4/Firmware master ECL was updated ~ 16 hours ago to the latest PX4/ecl master commit before the cmake changes, so projects forked prior to PX4/PX4-Autopilot@2e92484 aren't stuck.
Is there something broken that can't be fixed with updating both Firmware and ecl? |
|
The problem i have with the project I am working on at the moment is that the changes made by this PR break the build and there are a number of conflicts with PX4/PX4-Autopilot@2e92484 that I am now working through. |
|
Closing the PR, but keeping the branch for reference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #432
Requested because #432 breaks builds for projects forked prior to PX4/PX4-Autopilot@2e92484 that wish to use latest ecl and has not been peer reviewed.