This repository has been archived by the owner on May 1, 2024. It is now read-only.
EKF add estimator namespace and cleanup whitespace #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the python testing needs to be updated to work with the namespace. |
|
@dagar for dummies like me can you explain the benefit of the namespace change? TXS :) |
The idea is that if someone else has a free-standing method or a class with the same name, it won't collide. This would let us add an estimator::Filter as well as mavlink::Filter in the same compiled binary for example. |
|
@dagar The python tests and the swig library are now removed. Getting this in should be easier now. Would be cool if you could pick this up again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace and minor whitespace changes from #613.