change default update rate to 200 Hz #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dagar
commented
Apr 28, 2020
dagar
commented
- this goes along with the change PX4 side IMU: parameterize IMU integration time (IMU_INTEG_RATE) PX4-Autopilot#14759
dagar
force-pushed
the
pr-default_update_rate
branch
from
aa3085d to
2972966
Compare
julianoes
reviewed
Apr 29, 2020
There was a problem hiding this comment.
What I'm confused about is where the 500 Hz update rate went to because VTOL models did not fly well at 250 Hz simulation rate, so at 200 Hz it will be even worse. (I'm not talking about the rate at which the communication happens over MAVLink but the internal Gazebo rate.)
Edit:
Ok @Jaeyoung-Lim helped me understand this. It's presumably fixed with #471.
There was a problem hiding this comment.
@dagar @julianoes What is still not solved is the landing gear oscillating depending on the update rate. This will potentially change how the typhoon_h480 oscillates
dagar
force-pushed
the
pr-default_update_rate
branch
2 times, most recently
from
b71fb35 to
a176fe0
Compare
dagar
changed the title
|
Tested in PX4/PX4-Autopilot#14759. Iris looks fine, but the typhoon h480 landing gear are shaking at 200 Hz. |
- this goes along with the change PX4 side PX4/PX4-Autopilot#14759
dagar
force-pushed
the
pr-default_update_rate
branch
from
a176fe0 to
2019c55
Compare
julianoes
approved these changes
May 4, 2020
|
This is stale, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.