Update Documentation For New Septentrio-Specific Driver #3253
Conversation
As the Septentrio driver has moved from the PX4 GPS drivers repository into the main codebase and received new parameters and features, the documentation needs to be updated to reflect them.
flyingthingsintothings
force-pushed
the
pr-new-septentrio-driver
branch
from
53fb463 to
d53588a
Compare
| Note that you can also use a secondary Septentrio GNSS module, which is configured in a similar way. | ||
| It is common to connect a second module to the port labeled `GPS 2` | ||
| The port is configured using the [SEP_PORT2_CFG](../advanced_config/parameter_reference.md#SEP_PORT2_CFG) parameter. |
|
Thanks @flyingthingsintothings this is good thanks. I have subedited it for style - in particular for your note:
|
There was a problem hiding this comment.
@flyingthingsintothings OK, I'm going to merge, but probably a good idea for you to look at the current version and make sure my edits didn't change anything "incorrectly".
Note, one thing missing, which you can do as a post process. I think you need to add EKF2 settings to enable yaw, such as these https://docs.px4.io/main/en/gps_compass/rtk_gps_holybro_unicore_um982.html#enable-gps-heading-yaw
|
No flaws found |
|
@hamishwillee I didn't find in the contribution guidelines that Prettier was used for formatting. That could maybe be added. Thank you for the edits. I always use max line length but like you say, splitting on sentences does make more sense. |
|
@flyingthingsintothings I guess it is a bit unreasonable for you to guess the requirements :-). Thanks for the timely reminder! I have made an update in #3261 |
|
Thanks for this @flyingthingsintothings, helped me today! ❤️ |
|
@hamishwillee this PR needs backporting to v1.15! It looks like the feature was shoved into v1.15 last minute. |
|
@julianoes Well that's annoying. I manually removed it after the first cut of the build because it wasn't present :-( |
As the Septentrio driver has moved from the PX4 GPS drivers repository into the main codebase and received new parameters and features, the documentation needs to be updated to reflect them. I checked the changes with
yarn startand everything looks normal. There is one missing link (see bot reply below) which is just a future link that will point to the new parameters once they are available in the documentation, as that will automatically happen from what I understand.