added sf45 as a seperate rangefinder #3448
Conversation
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
e14bb3c to
4270c05
Compare
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
4270c05 to
4376433
Compare
|
This is IMO ready when your PR is ready - thanks very much!!! I did some restructure to make the new rangefinder doc a sub-doc - that allows us to expand the structure if we want in future. Note that the build error can be ignored. It happens because I moved one of the image files alongside the other, and the existing translations depend on that location. This will be fixed after merging by crowdin. |
hamishwillee
force-pushed
the
pr-sf45
branch
2 times, most recently
from
2d2246c to
a32bec6
Compare
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
b561ee8 to
3b6e6d0
Compare
|
I've separately added a PR the lanbao, so that this isn't mixed in with this PR about #3487 |
hamishwillee
force-pushed
the
pr-sf45
branch
from
1dbe41f to
43c85a9
Compare
en/sensor/sf45_rotating_lidar.md
Outdated
|
|
||
| <video src="../../assets/hardware/sensors/lidar_lightware/sf45_plotjuggler.mp4" width="720" controls></video> | ||
|
|
||
| In order to generate this kind of plot you will need to add the following Reactive Scripts to PlotJuggler. |
There was a problem hiding this comment.
What is a Reactive Script? Is there a good link to a definition we can add here for someone wanting to learn more?
There was a problem hiding this comment.
Reactive scripts are Lua scripts inside plot juggler, sadly the documentation for PlotJuggler is severely lacking. So there's no good source on what it actually is.
| In order to generate this kind of plot you will need to add the following Reactive Scripts to PlotJuggler. | ||
| If you save these scripts and then add new data, you will see a new timeseries called `obstacle_distance_xy`, which is the same as is displayed in the video. | ||
|
|
||
| **Global code, executed once:** |
There was a problem hiding this comment.
Is it bleedingly obvious how you execute/add these scripts? If not then we need to either add a link to instructions or explain how here. Up to you which.
There was a problem hiding this comment.
Sadly not, i'll add a screenshot, and mention where the setting is.
There was a problem hiding this comment.
@Claudio-Chies I'm going to merge this, but ...
I've added a tip above in 55fcd83 to link to the more extensive example you provided in Collision prevention.
Do we need both sets of scripts and examples? In the tip I have said "go here for more info" since that shows how to get scripts working, but they do more or less the same thing right? I wonder if having two scripts like this makes sense? [why wouldn't you just use the collision prevention stuff?]
|
Can we get the video on PX4 youtube and link it. The file is not huge, but obviously it is cheaper if authors don't have to download it for local editing |
|
a video of the SF45. the plotjuggler layout or of the drone flying? |
The plotjuggler layout. Sorted by the other PR probably. |
|
@hamishwillee how could I get the video onto PX4 YouTube? |
|
You want the one in this PR too? I can upload it for you if you want? |
|
Might make sense to keep the filesize low? i think here its a good visualisation on how the sensor operates |
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
8d256f4 to
78a9d4f
Compare
|
No wo;rries. File is uploading. Link will be https://youtu.be/VwEd_7aiLEo |
|
@hamishwillee this would be ready to merge, as the parent was merged |
|
No flaws found |
Relevant PR's