Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rover flight modes: Specify speed axis #3530

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

chfriedrich98
Copy link
Contributor

Rewording to differentiate between longitudinal (forward/backwards) and lateral (left/right) motion.

@hamishwillee
Copy link
Collaborator

@chfriedrich98 I'm back from holiday - hope you had a good Xmas/New year time. Let me know your thoughts on this.

Copy link

No flaws found

@chfriedrich98
Copy link
Contributor Author

@hamishwillee Welcome back, hope you had a nice holiday!
I was just googling the complement for "lateral speed" and came across "longitudinal speed", but if that is not a common word I agree with changing it back to make it easier to understand. (I wasn't aware of that word either before looking it up :) )

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 30, 2025

@hamishwillee Welcome back, hope you had a nice holiday!

I did thanks! Looking out the window on a sunny day and wishing I was allowed out of my box :-(

I was just googling the complement for "lateral speed" and came across "longitudinal speed", but if that is not a common word I agree with changing it back to make it easier to understand. (I wasn't aware of that word either before looking it up :) )

It's not that it is uncommon as unsual in this context. If I give someone an RC controller, I would tell them to drive forwards or backwards, left or right. I wouldn't tell them to drive longitudinally. However I would use lateral to differentiate a left right movement from a left/right turn (as in an FW).

I would use longitudinal to describe an axis of something like a box that had no obvious front.

So this is a matter of what will require zero thinking for the user.

Thanks for the changes. Merging as all good.

@hamishwillee hamishwillee merged commit 45adac8 into PX4:main Jan 30, 2025
3 checks passed
@chfriedrich98 chfriedrich98 deleted the rover_update branch January 30, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants