-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rover flight modes: Specify speed axis #3530
Conversation
3749696
to
093921e
Compare
@chfriedrich98 I'm back from holiday - hope you had a good Xmas/New year time. Let me know your thoughts on this. |
Co-authored-by: Hamish Willee <[email protected]>
No flaws found |
@hamishwillee Welcome back, hope you had a nice holiday! |
I did thanks! Looking out the window on a sunny day and wishing I was allowed out of my box :-(
It's not that it is uncommon as unsual in this context. If I give someone an RC controller, I would tell them to drive forwards or backwards, left or right. I wouldn't tell them to drive longitudinally. However I would use lateral to differentiate a left right movement from a left/right turn (as in an FW). I would use longitudinal to describe an axis of something like a box that had no obvious front. So this is a matter of what will require zero thinking for the user. Thanks for the changes. Merging as all good. |
Rewording to differentiate between longitudinal (forward/backwards) and lateral (left/right) motion.