Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Add "Steps per hour" system setting #211

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Add "Steps per hour" system setting #211

merged 6 commits into from
Aug 20, 2024

Conversation

szdarkhack
Copy link
Contributor

This implements a "Steps per hour" system setting to be returned from PTM:GetStepHistory, as described in issue #208.

Currently the setting is global (i.e. not per-game).

@PabloMK7
Copy link
Owner

Can you send screenshot of the new UI? Also, would you be able to add the setting to android?

@szdarkhack
Copy link
Contributor Author

szdarkhack commented Jul 21, 2024

The UI is shown below. I've tried my best to maintain the existing style and made sure it doesn't show in the per-game config.

image

I don't think I'll be able to do the Android UI, at least not for now, but I can try it when I get some spare time again. Also I tried to make the setting work per-game but failed, I certainly intend to take another crack at that at some point (if noone beats me to it).

Any suggestions for improving the setting label or any such detail are of course welcome. Maybe "Pedometer steps per hour" would be clearer?

@szdarkhack
Copy link
Contributor Author

szdarkhack commented Jul 25, 2024

Terribly sorry, I just realized I had the wrong author set so I had to amend and force push.

Copy link
Owner

@PabloMK7 PabloMK7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to edit the non-qt citra so that it loads the setting from the .ini file. Also edit the Android files so that it does the same (even if no UI exists).
Take a look at the config.cpp changes in #209

@szdarkhack
Copy link
Contributor Author

I've made the requested changes and tested that the ini value is properly loaded (and works as intended) for both the SDL frontend and the android version.

@szdarkhack szdarkhack requested a review from PabloMK7 August 3, 2024 07:25
@PabloMK7 PabloMK7 merged commit e1ff3b8 into PabloMK7:master Aug 20, 2024
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants