This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Refactor Vulkan stream buffer memory type selection #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for GPUs with Vulkan V1.1 and V1.2
raphaelthegreat
approved these changes
Aug 22, 2024
|
Did the requested refactoring and fixed the clang format check |
|
clang format again |
fight-fly
reviewed
Aug 23, 2024
|
Can you merge this @PabloMK7 or there are some other needed tests? |
PabloMK7
approved these changes
Aug 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for GPUs with Vulkan V1.1 and V1.2.
This Fix is merged as of now in Lime3DS and tested working (commit #384 in Lime3DS)
Fixes Issue #233 in here.