This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
am: Fix too much file handle cause memory leak, this fix cia installation #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloMK7
suggested changes
Oct 11, 2024
|
I think the title can be considered to add some words like these Thank you, you do a good job. |
R-YaTian
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cia has more than 507 ncch content, am service will open too much file handle which cause memory leak.
This PR will fix this issue by checking content count, if content count big than 255, will close the file handle after used, and reopen it next time.
Now we can install MM4 DLC which has 711 ncch content.
Tested it on Windows and works fine...