-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thread '<unnamed>' panicked at 'called Result::unwrap()
#4
Comments
Thanks for describing the issue Joana, The easiest way for us to help with this would be if you can share the log output, and ideally the data you're analyzing (or even better a minimized version of it). Please let me know and I can setup a share for you if this is possible. If not, we can at least go ahead and get a better error message on that unwrap call, to help get some more specific information on what could be happening in this case. |
So this is what I am running: ./hificnv --bam PACBIO_HPRC_bams_mapped2h38/HG00621.sorted.bam --ref human_GRCh38.p14/GCF_000001405.40_GRCh38.p14_genomic.fna --threads 20 --output-prefix HG00621 The HPRC PACBIO HiFi reads for S3/HG00621 were mapped to h38 using minimap2 as follows: are there any specific requirements or params for minimap2 I would need to use? I used HG00621.sorted.bam to run deepVariant with the PacBIO model and it worked. Same to get vcfs for SV calling using other softwares like pbsv. Here is the log info: [2023-03-17][10:34:27][hificnv][INFO] Starting hificnv |
As a follow up: Using the sample example sample (HG00621), when Reference used for minimap2 is GCF_002880755.1_Clint_PTRv2_genomic.fna: For the sampe sample, when Reference is GCF_000001405.40_GRCh38.p14_genomic.fna: |
Thanks Joana, The second issue is very clear -- in the short term you could work around this problem by remapping with pbmm2, which is our recommended read mapper for HiFi. This brings up the issue that we haven't tested HiFiCNV for minimap2, and hadn't come up with a support policy yet, so we'll consider our options and clarify this soon. For the first issue (PoisonError), I would expect to see it only as a secondary error message -- there typically should be an original panic/error message occurring first which leads to the failed unwrap later on. I think we can add some changes to the code to simplify and clarify the error messages for cases like this, but in the short term if you're able to spot the very first panic/error message in the log for this case, it might point to a more specific issue -- if all of these samples are mapped with minimap2, I wouldn't be surprised if the CIGAR string format was the complication for all of these samples. |
Hi @joanocha, this should be fixed with the latest release which can be found here: https://github.com/PacificBiosciences/HiFiCNV/releases/tag/v0.1.6 |
Thanks @holtjma I'll try this new version too |
Hi! I just double checked and the input bams seem to match the chromosome names of the reference. The thing is that the chromosome names are not chr 1,2 but rather the NCBI codes NC_#####. |
Hi @joanocha HiFiCNV currently looks for a set of diploid autosomes to estimate the GC-bias of the sample. To do do it matches chromosome names against a regular expression which can be set on the cmdline:
For the case you describe, you could start by setting this argument so that all chromosomes are used for GC-bias correction by adding the following to your cmdline: We'll discuss possible changes to the gc-bias correction to see if this setting can be simplified out. |
I'm now running the newest release however I have a new issue: |
@Gedofs This error is only supposed to show up when a chromosome is encountered in the BAM file that is not present in your reference genome file. Can you verify that you are using the same reference file for both the upstream alignment and HiFiCNV? If so, it may be a good idea to open a separate issue so we can track it separate from this closed one. |
Ok, I'll check it out.
El lun, 3 abr 2023 a las 12:10, Matt Holt ***@***.***>)
escribió:
… @Gedofs <https://github.com/Gedofs> This error is only supposed to show
up when a chromosome is encountered in the BAM file that is *not* present
in your reference genome file. Can you verify that you are using the same
reference file for both the upstream alignment and HiFiCNV? If so, it may
be a good idea to open a separate issue so we can track it separate from
this closed one.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPDKHEBW4IA4R2MQKPMWSDW7MHATANCNFSM6AAAAAAV5422NE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks, you are right. This time i used the reference used to make my BAM
(GCA_000001405.15_GRCh38_no_alt_analysis_set.fna), however there is a new
issue...
[2023-04-04][16:43:49][hificnv][INFO] Starting hificnv
[2023-04-04][16:43:49][hificnv][INFO] cmdline: hificnv --bam
/Datos/sample.0-0.bam --ref
/Datos/GCA_000001405.15_GRCh38_no_alt_analysis_set.fna --exclude
/Datos/cnv.excluded_regions.common_50.hg38.bed.gz --expected-cn
/Datos/female_expected_cn.hg38.bed --threads 3 --output-prefix 001
[2023-04-04][16:43:49][hificnv][INFO] Running on 3 threads
[W::hts_idx_load3] The index file is older than the data file:
/Datos/sample.0-0.bam.bai
[2023-04-04][16:43:49][hificnv][INFO] Reading reference genome from file
'/Datos/GCA_000001405.15_GRCh38_no_alt_analysis_set.fna'
[2023-04-04][16:44:30][hificnv][INFO] Reading excluded regions from file
'/Datos/cnv.excluded_regions.common_50.hg38.bed.gz'
[2023-04-04][16:44:30][hificnv][INFO] Reading expected CN regions from file
'/Datos/female_expected_cn.hg38.bed'
[2023-04-04][16:44:30][hificnv][INFO] Processing alignment file
'/Datos/sample.0-0.bam'
[W::hts_idx_load3] The index file is older than the data file:
/Datos/sample.0-0.bam.bai
[W::hts_idx_load3] The index file is older than the data file:
/Datos/sample.0-0.bam.bai
[W::hts_idx_load3] The index file is older than the data file:
/Datos/sample.0-0.bam.bai
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None`
value', src/bam_scanner.rs:234:41
note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace
El lun, 3 abr 2023 a las 12:13, Gerardo Fabián ***@***.***>)
escribió:
… Ok, I'll check it out.
El lun, 3 abr 2023 a las 12:10, Matt Holt ***@***.***>)
escribió:
> @Gedofs <https://github.com/Gedofs> This error is only supposed to show
> up when a chromosome is encountered in the BAM file that is *not*
> present in your reference genome file. Can you verify that you are using
> the same reference file for both the upstream alignment and HiFiCNV? If so,
> it may be a good idea to open a separate issue so we can track it separate
> from this closed one.
>
> —
> Reply to this email directly, view it on GitHub
> <#4 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWPDKHEBW4IA4R2MQKPMWSDW7MHATANCNFSM6AAAAAAV5422NE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@Gedofs Can you make a new issue so we don't lose track of it in this closed issue? The problem you're experiencing seems unrelated to Joana's original problem. |
Will do.
El mar, 4 abr 2023 a las 12:52, Matt Holt ***@***.***>)
escribió:
… @Gedofs <https://github.com/Gedofs> Can you make a new issue so we don't
lose track of it in this closed issue? The problem you're experiencing
seems unrelated to Joana's original problem.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPDKHEYQNOHF4JCGCUWS2LW7RUXXANCNFSM6AAAAAAV5422NE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi,
I tried running the latest version of HiFiCNV and got the following error:
thread '' panicked at 'called
Result::unwrap()
on anErr
value: PoisonError { .. }', src/bam_scanner.rs:72:63I tried to run with 1 thread, 20 threads or without specifying threads and I am still getting the same error. Any thoughts on what could be going on? It seems to be something rust-related and an error is being reported but the message does not really explain what is the underlying issue or the error.
Any help would be much appreciated!
Thanks
Joana
The text was updated successfully, but these errors were encountered: