Merge pull request #6 from Padam87/options_bugfix

Fixed phantomjs options associative config
Padam87 · Aug 28, 2015 · a427fd5 · a427fd5
2 parents 7a41b8c + cee338c
commit a427fd5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ConfigHelper.php b/ConfigHelper.php
@@ -217,7 +217,7 @@ protected function processPhantomjsOptions()
                 if (is_bool($value)) {
                     $value = ($value) ? 'true' : 'false';
                 }
-                $options[] = sprintf('%s="%s"', $name, $value);
+                $options[] = sprintf('%s=%s', $name, $value);
             }
         }
 

diff --git a/Tests/ConfigHelperTest.php b/Tests/ConfigHelperTest.php
@@ -126,7 +126,7 @@ public function arePhantomjsOptionsHandled()
         $process = $this->configHelper->buildProcess($url, 'e4e5k2');
 
         $this->assertContains(
-            ProcessUtils::escapeArgument(sprintf('%s="%s"', '--ignore-ssl-errors', 'true')),
+            ProcessUtils::escapeArgument(sprintf('%s=%s', '--ignore-ssl-errors', 'true')),
             $process->getCommandLine()
         );