Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpu support for fill_constant Op #27675

Merged
merged 28 commits into from
Oct 14, 2020
Merged

xpu support for fill_constant Op #27675

merged 28 commits into from
Oct 14, 2020

Conversation

wangchaochaohu
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

add xpu support for fill_constant Op for Paddle

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 30, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 30, 2020
Thunderbrook
Thunderbrook previously approved these changes Oct 12, 2020
View reviewed changes
zhupengyang
zhupengyang previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @unittest.skipIf(not paddle.is_compiled_with_xpu()

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 13, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 13, 2020
@wangchaochaohu wangchaochaohu merged commit c5fcc96 into PaddlePaddle:develop Oct 14, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@wangchaochaohu @chen-zhiyu
xpu support for fill_constant Op (PaddlePaddle#27675)
9f79570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@zhupengyang zhupengyang zhupengyang approved these changes

@Thunderbrook Thunderbrook Thunderbrook left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangchaochaohu @CLAassistant @luotao1 @zhupengyang @Thunderbrook