Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【paddle.fleet】fix sparse load #27680

Merged
merged 24 commits into from
Oct 14, 2020

Conversation

MrChengmo
Copy link
Contributor

PR types

New features,Bug fixes

PR changes

OPs,Others

Describe

修复了重构PS后, 参数服务器加载模型的问题

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -267,6 +267,36 @@ void SerializeToStream(std::ostream &os, const LoDTensor &tensor,
TensorToStream(os, static_cast<Tensor>(tensor), dev_ctx);
}

void DeserializeFromStream(std::istream &is, LoDTensor *tensor,
const platform::DeviceContext &dev_ctx,
const int64_t &node_index, const int64_t &node_num,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the meaning node_index and node_num ?

@@ -78,6 +78,10 @@ void TensorFromStream(std::istream& is, Tensor* tensor,
void TensorFromStream(std::istream& is, Tensor* tensor,
const platform::DeviceContext& dev_ctx,
const size_t& seek, const std::vector<int64_t>& shape);
void TensorFromStream(std::istream& is, Tensor* tensor,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要额外➕ 这些方法?

@seiriosPlus
Copy link
Collaborator

LGTM

@MrChengmo MrChengmo merged commit 328cb28 into PaddlePaddle:develop Oct 14, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants