Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0rc api rename #28088

Merged
merged 16 commits into from
Oct 21, 2020
Merged

2.0rc api rename #28088

merged 16 commits into from
Oct 21, 2020

Conversation

liuhuiCNN
Copy link
Contributor

@liuhuiCNN liuhuiCNN commented Oct 19, 2020

PR types

Function optimization

PR changes

APIs

Describe

(1) rename manual_seed-->seed
(2) rename xxx1d-->xxx1D, xxx2d-->xxx2D, xxx3d-->xxx3D

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 19, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

raindrops2sea
raindrops2sea previously approved these changes Oct 20, 2020
heavengate
heavengate previously approved these changes Oct 20, 2020
XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 20, 2020
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 20, 2020
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XiaoguangHu01 XiaoguangHu01 merged commit 7c1aa0d into PaddlePaddle:develop Oct 21, 2020
XiaoguangHu01 pushed a commit that referenced this pull request Oct 21, 2020
* rename manual_seed to seed

* rename xxx1d-->xxx1D, xxx2d-->xxx2D, xxx3d-->xxx3D

* rename manual_seed --> seed

* do not rename .cc, .cu and .h file

* rename manual_seed --> seed

* rename manual_seed --> seed

* rename manual_seed --> seed

* rename manual_seed --> seed

* disable_static on doc example code

* donot change manual_seed on generator

* add enable_static on sample code

* convert python/paddle/fluid/layers/nn.py to bak

* fix typo

* fix code style

* fix seed to manual_seed when call functions of Generator()

* fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants