lamb_op_xpu;test=kunlun #31012
Merged
lamb_op_xpu;test=kunlun #31012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
QingshuChen
reviewed
Feb 18, 2021
| } | ||
| } | ||
| }; | ||
| #endif |
There was a problem hiding this comment.
整个文件都可以放在ifdef PADDLE_WITH_XPU中，没必要分两个。
| T beta2 = static_cast<T>(ctx.Attr<float>("beta2")); | ||
| auto& param = GET_DATA_SAFELY(ctx.Input<LoDTensor>("Param"), "Input", | ||
| "Param", "Lamb"); | ||
| // auto* grad_var = ctx.InputVar("Grad"); |
| PADDLE_ENFORCE_EQ( | ||
| r, xpu::Error_t::SUCCESS, | ||
| platform::errors::InvalidArgument( | ||
| "XPU kernel error of RmspropOp, error message: INVALID_PARAM, " |
| PADDLE_ENFORCE_EQ(r, xpu::Error_t::SUCCESS, | ||
| platform::errors::Unavailable( | ||
| "XPU kernel error of RmspropOp, error message: " | ||
| "RUNTIME_ERROR, please check whether Baidu " |
| "Output", "Beta2PowOut", "Lamb"); | ||
| auto& dev_ctx = ctx.template device_context<DeviceContext>(); | ||
|
|
||
| int r = xpu::lamb( |
There was a problem hiding this comment.
现在这个kernel是不是支持了所有可能性？比如稀疏等等？ 不支持的要先抛异常
Thunderbrook
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
Ops
Describe
add lamb_op_xpu