support multi node in heterps #31102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
danleifeng
reviewed
Feb 24, 2021
| @@ -386,3 +386,27 @@ def __init__(self): | |||
| def _transpile_startup_program(self): | |||
| block = self.startup_program.global_block() | |||
| block.append_op(type='c_comm_init_all', attrs={'ring_id': 0}) | |||
|
|
|||
|
|
|||
| class MultiThread(GradAllReduce): | |||
There was a problem hiding this comment.
需要在minimize中添加MultiThread的使用
| @@ -111,6 +173,12 @@ class HeterComm { | |||
| CustomGradMerger merger_; | |||
| int topo_aware_{1}; | |||
| std::vector<std::vector<Path>> path_; | |||
| std::vector<LocalStorage> storage_; | |||
| int feanum_{1800 * 2048}; | |||
| int multi_node_{1}; | |||
| @@ -54,7 +54,14 @@ void HeterPs::show_one_table(int gpu_num) { comm_->show_one_table(gpu_num); } | |||
|
|
|||
| void HeterPs::push_sparse(int num, FeatureKey* d_keys, | |||
| FeaturePushValue* d_grads, size_t len) { | |||
| comm_->push_sparse(num, d_keys, d_grads, len, opt_); | |||
| // comm_->push_sparse(num, d_keys, d_grads, len, opt_); | |||
| comm_->push_sparse_multi_node(num, d_keys, d_grads, len, opt_); | |||
There was a problem hiding this comment.
需要加入单机多机的判断，走push_sparse 或 push_sparse_multi_node
danleifeng
approved these changes
Feb 24, 2021
Thunderbrook
added a commit
to Thunderbrook/Paddle
that referenced
this pull request
Mar 1, 2021
* push multi node * multi node * MultiThread * remove log * solve bug in 30829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
support multi node in heterps mode