Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ELU output for nan, test=develop #31132

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix ELU output for nan, test=develop #31132

merged 1 commit into from
Mar 2, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Feb 23, 2021

PR types

Bug fixes

PR changes

OPs

Describe

Fix issue of #29912

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@qili93
Copy link
Contributor Author

qili93 commented Feb 23, 2021

New output after this fix is

image

@qili93 qili93 mentioned this pull request Feb 23, 2021
Merged
@qili93 qili93 requested a review from zhupengyang February 23, 2021 03:18
zhupengyang
zhupengyang approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit pushed a commit that referenced this pull request Feb 23, 2021
@qili93
[Cherry-pick] fix ELU output for nan, test=develop (#31135)
b582be2 
ATT, cherry pick of #31132
@qili93 qili93 requested a review from GaoWei8 March 2, 2021 09:30
GaoWei8
GaoWei8 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@GaoWei8 GaoWei8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

@qili93 qili93 merged commit ec72f5b into PaddlePaddle:develop Mar 2, 2021
@qili93 qili93 deleted the fix_elu_dev branch March 2, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhupengyang zhupengyang zhupengyang approved these changes

@GaoWei8 GaoWei8 GaoWei8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qili93 @zhupengyang @GaoWei8