Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom OP]add MSVC compile check on Windows #31265

Merged
merged 2 commits into from
Feb 28, 2021

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Feb 26, 2021

PR types

New features

PR changes

OPs

Describe

Add compiler check on Windows.

Compiler should be MSVC with cl.exe on windows, and MSVC compile Version must be >= 19.0.24215.

If Not, it will has Warning:

*************************************
*  Compiler Compatibility WARNING   *
*************************************

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Found that your compiler (ninja.exe) is not compatible with the compiler 
built Paddle for this platform, which is cl.exe on win32. Please
use cl.exe to compile your custom op. Or you may compile Paddle from
source using ninja.exe, and then also use it compile your custom op.

See https://www.paddlepaddle.org.cn/documentation/docs/zh/install/compile/fromsource.html
for help with compiling Paddle from source.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 26, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 26, 2021
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit cc89120 into PaddlePaddle:develop Feb 28, 2021
chenwhql pushed a commit to chenwhql/Paddle that referenced this pull request Feb 28, 2021
lanxianghit pushed a commit that referenced this pull request Feb 28, 2021
* modify custom op dependent from paddle_framework to paddle_custom_op (#31195)

* [Custom Op] Remove unsupport dtypes (#31232)

* remove remove_unsupport_dtype

* remove remove_unsupport_dtype

* remove test dtype

* add more include

* change dtype.h's enum as enum class to avoid conflict with inference lib

* make enum as enum class

* remove additional test

* merge develop

* polish code

* [Custom OP] Support stream set on Custom Op (#31257)

* [Custom OP] change the user header file format, test=develop (#31274)

* [Custom OP]add PD_THROW and PD_CHECK for User Error message (#31253)

* [Custom OP]add PD_THROW and PD_CHECK for User error message

* PD_THROW and PD_CHECK, fix comment

* fix Windows error message

* fix Windows error message

* fix CI

* [Custom OP]add MSVC compile check on Windows (#31265)

* fix test_check_abi

Co-authored-by: Zhou Wei <[email protected]>
Co-authored-by: Jiabin Yang <[email protected]>
Co-authored-by: 石晓伟 <[email protected]>
Co-authored-by: zhouwei25 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants